Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia plugin: get cooler RPM instead of percentage #86

Closed
wants to merge 1 commit into from
Closed

nvidia plugin: get cooler RPM instead of percentage #86

wants to merge 1 commit into from

Conversation

monsta
Copy link
Contributor

@monsta monsta commented Aug 27, 2018 •
edited
Loading

This should fix #84. Unfortunately, I can't test it myself. My home GT 730 doesn't expose fan data at all, and another GT 730 at work only exposes fan level in percentage.

Requirements:

  • nvidia card with fan
  • proprietary drivers
  • libxnvctrl >= 331.13

If your card supports exposing fan data, there should be a new CoolerSpeed sensor in the applet's prefs dialog. It replaces CoolerLevel sensor. Yes, I've renamed it to match its purpose.

The sensor should show the same fan speed as nvidia-settings does.

@monsta
nvidia plugin: get cooler RPM instead of percentage
0f8395c 
requires libxnvctrl >= 331.13

fixes #84
@monsta monsta requested a review from a team August 27, 2018 13:50
@monsta monsta mentioned this pull request Aug 27, 2018
Open
@raveit65
Copy link
Member

Sorry, my gt1030 is fanless.

raveit65
raveit65 requested changes Aug 28, 2018
View reviewed changes
Copy link
Member

@raveit65 raveit65 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks a lot. My card have a sensor which value is zero of course.
Without the PR the sensor is enabled it displays simply 0.
Now i got frequently an error notification from m-n-d.
And tooltip shows an error too.
sensor-applet

@monsta
Copy link
Contributor Author

monsta commented Aug 28, 2018

Ok, this is how plugin reacts to unsupported attribute returned from libxnvctrl... then it passes GError to the applet, and there's this reaction with notifications. I see the same on a card which has a fan but doesn't support exposing speed in RPMs.

nvsettings

@raveit65
Copy link
Member

@monsta
Any progress?

@monsta
Copy link
Contributor Author

monsta commented Nov 20, 2018

Sorry, not yet. I'll try to get back to it this weekend...

@raveit65
Copy link
Member

@monsta
Personal i can live with the error message because i have a fanless card.
I always disable sensors which i don't need.
And the error notification displays only one time.

@raveit65
Copy link
Member

@monsta
I do have a GT1030 with a fan for testing, so we can re-start this PR again.
It looks like i need this
Bildschirmfoto zu 2019-03-13 18-45-14

gpu-z under Win10 shows me 35% in idle.

@raveit65
Copy link
Member

@monsta
But i get an error warning when i enable the fan sensor with that patch.
No idea to debug this.

@raveit65
Copy link
Member

raveit65 commented Mar 13, 2019 •
edited
Loading

Seems my card doesn't support reading RPM fanspeed and can't be used to test this PR.
Bildschirmfoto zu 2019-03-13 20-12-41

@raveit65 raveit65 closed this Apr 25, 2021
@raveit65 raveit65 deleted the nvidia-cooler-rpm branch April 25, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raveit65 raveit65 raveit65 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NVIDIA Fan Speed showing percentage speed instead of RPM
2 participants
@monsta @raveit65